Skip to content

CosmeticArmorReworked ​

6 merged pull requests.

New Features ​

  • #8 ContainerCosArmor slot validation in both cosmetic slot constructors now accepts ItemSkull for the head slot (index 0) in addition to ItemBlock and helmet armor. - @Algent
    • Added: skulls in the cosmetic head slot
  • #5 Modified ContainerCosArmor to allow block items in addition to armor items for the head slot. - @Ranzuu
    • Added: Block item support in head armor slot

Changes ​

  • #1 Keyboard.KEY_C became Keyboard.KEY_NONE, and the ClientTickEvent polling of getIsKeyPressed() was replaced with an InputEvent.KeyInputEvent handler using isPressed(), so the open packet fires once per press instead of every tick the key is held. - @Alexdoru

Bug Fixes ​

  • #6 GuiCosArmorButton no longer draws its label. GuiEvents.guiPostDraw draws a tooltip for the hovered button through a new GuiScreenTooltipHelper in the net.minecraft.client.gui package. The en_US.lang strings were edited. - @Elyspio
    • Added: Tooltip rendering for the cosmetic armor button
    • Fixed: Cosmetic armor button tooltip rendering, Missing spaces in cosmetic armor lang strings
  • #4 Removed the potion effect and NEI-hidden offset logic from GuiCosArmorInventory.initGui and GuiEvents.guiPostInit, and deleted the reflective isNeiHidden helper. - @Alexdoru
    • Removed: Potion effect offset for cosmetic armor buttons
    • Fixed: Cosmetic armor button position with potion effects
  • #2 Removed retained world references in PlayerRenderHandler, InventoryManagerClient, and NetworkManager; added proper cleanup in GuiHandler and CosmeticArmorReworked on world unload events. - @Alexdoru
    • Removed: Unnecessary retained state in rendering handlers
    • Fixed: Memory leak from held world references, Client-side state not clearing on world unload

Contributors ​

Everyone who authored, reviewed or co-authored a change on this page, with how many of them:

@Alexdoru (3), @boubou19 (2), @koolkrafter5 (2), @Ranzuu (2), @Algent (1), @Elyspio (1), @jss2a98aj (1)